This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] pl_PL locale: fix collation [BZ #22469]


On 11/23/2017 02:54 AM, Mike FABIAN wrote:
> 
>       [BZ #22469]
>        * localedata/locales/pl_PL (LC_COLLATE): Use “copy "iso14651_t1"”
>        and implement the collation rules for pl from CLDR on top of that.
>        * Makefile: Add pl_PL.UTF-8 to test-input and to the list
>        of locales to be built for testing.
>        * pl_PL.UTF-8.in: New file with test data to test the Polish sorting.
> 
> The patch contains a test file: localedata/pl_PL.UTF-8.in
> This file shows how the strings are sorted in Polish locale after the  patch is
> applied. It improves the sorting of some characters not used in Polish
> like Ʒ, because these were not handled at all in the original LC_COLLATE
> of the Polish locale and are now  sorted better because of the
> “copy "iso14651_t1"”. All characters actually used in Polish sort the
> same way as before.
> 

Well done. Thank you for the test, this is exactly what I like to see going into
these kinds of changes. A list of explicit orders to test that may include
comments on why the ordering is the way it is.

Looks good to me.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]