This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix typo in variable name in gen-locale.sh [committed]


On 11/22/2017 03:46 PM, Jonathan Nieder wrote:
> Joseph Myers wrote:
> 
>> 2017-11-22  Joseph Myers  <joseph@codesourcery.com>
>>
>> 	* localedata/gen-locale.sh: Fix typo in variable name.
> 
> Good catch.  The fix is obviously correct.
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Agreed, and it's my fault. I only tested SHIFT_JIS locales for the SUSE
builds. And given that we don't have any officially SUPPORTED ones, we
never see any issues here.

>> diff --git a/localedata/gen-locale.sh b/localedata/gen-locale.sh
>> index 757a0e9..39f1475 100644
>> --- a/localedata/gen-locale.sh
>> +++ b/localedata/gen-locale.sh
>> @@ -69,7 +69,7 @@ fi
>>  # warning. See localedata/Makefile $(INSTALL-SUPPORTED-LOCALES)
>>  # for the same logic.
>>  if [ "$charmap_real" = 'SHIFT_JIS' ] \
>> -   || [ "$charmpa_real" = 'SHIFT_JISX0213' ]; then
>> +   || [ "$charmap_real" = 'SHIFT_JISX0213' ]; then
>>    flags="$flags --no-warnings=ascii"
>>  fi


-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]