This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] add attribute nonstring

From: Paul Eggert <eggert at cs dot ucla dot edu>
To: Joseph Myers <joseph at codesourcery dot com>, Martin Sebor <msebor at gmail dot com>
Cc: sellcey at cavium dot com, GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 20 Nov 2017 21:27:02 -0800
Subject: Re: [PATCH] add attribute nonstring
Authentication-results: sourceware.org; auth=none
References: <11c4caec-df98-12e6-c6f5-cfc95eb8b8d6@gmail.com> <1510783744.1836.25.camel@cavium.com> <b8fa0da8-49a4-1f6f-9d8d-204e5924aa52@gmail.com> <alpine.DEB.2.20.1711152313180.3674@digraph.polyomino.org.uk>

Joseph Myers wrote:

This patch is OK, with the corresponding change also to
sysdeps/unix/sysv/linux/s390/bits/utmp.h unless you have reason to believe
that version of bits/utmp.h doesn't need changing

Are similar changes also needed to bits/utmp.h and tosysdeps/unix/sysv/linux/s390/s390-32/utmp32.h? They also define these arrays.

Also, manual/users.texi should document that the relevant arrays are notnecessarily null-terminated.

Also, what about struct utmpx? It has similarly-named fields, which also appearto use strncpy format. This affects sysdeps/unix/sysv/linux/s390/bits/utmpx.h,sysdeps/unix/sysv/linux/s390/s390-32/utmpx32.h, sysdeps/gnu/bits/utmpx.h, andmanual/users.texi.

Follow-Ups:
- Re: [PATCH] add attribute nonstring
  - From: Joseph Myers

References:
- Re: [PATCH] add attribute nonstring
  - From: Martin Sebor
- Re: [PATCH] add attribute nonstring
  - From: Steve Ellcey
- Re: [PATCH] add attribute nonstring
  - From: Martin Sebor
- Re: [PATCH] add attribute nonstring
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]