This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] inet: add uint64_t accessors to in6_addr union




On Nov 11, 2017 23:27, "Florian Weimer" <fw@deneb.enyo.de> wrote:
* Shawn Landden:

> diff --git a/inet/netinet/in.h b/inet/netinet/in.h
> index f94b4b4e1c..72d5dec312 100644
> --- a/inet/netinet/in.h
> +++ b/inet/netinet/in.h
> @@ -215,11 +215,13 @@ struct in6_addr
>       uint8_t __u6_addr8[16];
>       uint16_t __u6_addr16[8];
>       uint32_t __u6_addr32[4];
> +     uint64_t __u6_addr64[2];
>        } __in6_u;

I believe this breaks ABI because it changes the alignment of struct
in6_addr.
Oh my bad. I think you are right, as it would have been 32-bit aligned.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]