Re: [PATCH v6 0/6] Fixup linux ttyname and ttyname_r [BZ #22145]

[Christian Brauner <christian dot brauner at mailbox dot org>]

On Fri, Nov 10, 2017 at 03:08:21PM -0500, Luke Shumaker wrote:
> From: Luke Shumaker <lukeshu@parabola.nu>
> 
> The theme of this patchset is to fixup the changes made in 15e9a4f.
> Fix a bug [BZ #22145] introduced in the commit (and add tests for both
> the bug it fixed and the bug it introduced!), update documentation to
> reflect the behavior introduced in the commit.
> 
> The FSF has my copyright assignment on file.
> 
> v2:
>  - See individual commit messages
> v3:
>  - Revise commit messages
>  - Revise ChangeLog messages
>  - Split one of the commits in to 2 separate commits
>  - Fix style of comments (no "*" on continued lines, 2 spaces after
>    trailing period)
>  - Fix whitespace style in the definition of is_mytty
> v4:
>  - Revise tst-ttyname
> v5:
>  - Revise tst-ttyname
> v6:
>  - No change, but resubmit entire patchset with new version
> 
> Luke Shumaker (6):
>   manual: Update to mention ENODEV for ttyname and ttyname_r
>   linux ttyname: Update a reference to kernel docs for kernel 4.10
>   linux ttyname: Change return type of is_pty from int to bool
>   linux ttyname and ttyname_r: Make the TTY equivalence checks
>     consistent
>   linux ttyname and ttyname_r: Don't bail prematurely [BZ #22145]
>   linux ttyname and ttyname_r: Add tests
> 
>  ChangeLog                             |  26 ++
>  manual/terminal.texi                  |   5 +
>  sysdeps/unix/sysv/linux/Makefile      |   3 +-
>  sysdeps/unix/sysv/linux/tst-ttyname.c | 625 ++++++++++++++++++++++++++++++++++
>  sysdeps/unix/sysv/linux/ttyname.c     |  59 ++--
>  sysdeps/unix/sysv/linux/ttyname.h     |  17 +-
>  sysdeps/unix/sysv/linux/ttyname_r.c   |  61 ++--
>  7 files changed, 714 insertions(+), 82 deletions(-)
>  create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname.c

I'm fine with the patch series and if people don't have further objections I'd
apply during this week.

Christian

> 
> -- 
> 2.15.0
>

Attachment: signature.asc
Description: PGP signature