This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid warnings
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com
- Date: Fri, 03 Nov 2017 14:55:19 +0000
- Subject: Re: [PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid warnings
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <59EF4CEC.8020301@arm.com> <59EF4D34.4020506@arm.com> <df408fe3-fdcc-f28e-8151-49f3a046804c@redhat.com> <59FC63F6.9090206@arm.com> <c80f9933-8c06-24c9-614b-e90067d37000@redhat.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 03/11/17 14:28, Florian Weimer wrote:
> On 11/03/2017 01:41 PM, Szabolcs Nagy wrote:
>>> I think the preferred syntax is to put the attribute before the return type; after the type, it would apply to
>>> the type, and not the function, and GCC has hacks to support that, but that will only work for some types.
>>>
>> hm.. current uses of unused attribute for the
>> same purpose come after the return type:
>
> I meant the preferred syntax on the GCC side. But it was just a suggestion. For the unused attribute, the
> distinction truly does not matter.
>
i see.
i committed the patch as is,
we can fix the order later together with other attributes.
(although the plan is to drop this code eventually)