This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] test-errno-linux: quotactl can fail with EPERM in containers

From: Florian Weimer <fweimer at redhat dot com>
To: libc-alpha at sourceware dot org
Date: Thu, 2 Nov 2017 13:57:08 +0100
Subject: Re: [PATCH] test-errno-linux: quotactl can fail with EPERM in containers
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 28F3D49023
References: <20171021153947.1561442D83177@oldenburg.str.redhat.com> <385e73a5-c0aa-27a6-26ab-f14c8b431328@linaro.org>

On 10/30/2017 12:25 PM, Adhemerval Zanella wrote:


On 21/10/2017 13:39, Florian Weimer wrote:

2017-10-21  Florian Weimer<fweimer@redhat.com>

	test-errno-linux: quotactl can fail with EPERM in containers.
	* sysdeps/unix/sysv/linux/test-errno-linux.c
	(LIST, LIST_FORWARD): New macros.
	(check_error_in_list): New function.
	(test_wrp_rv): Accept list of permitted error codes.
	(test_wrp_rv2): Remove.
	(test_wrp): Call test_wrp_rv with list of error codes.
	(test_wrp2): Accept list of error codes.
	(do_test): Adjust.  Allow EPERM for quotactl.

I think it is worth a comment about this possible failure case below
the test.

Reviewed-by: Adhemerval Zanella<adhemerval.zanella@linaro.org>


Thanks, I pushed this with an updated comment.

Florian

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]