This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] New generic sinf
- From: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- To: libc-alpha at sourceware dot org, Joseph Myers <joseph at codesourcery dot com>
- Date: Thu, 2 Nov 2017 13:57:51 +0530
- Subject: Re: [PATCHv2] New generic sinf
- Authentication-results: sourceware.org; auth=none
- References: <1509436736-23436-1-git-send-email-raji@linux.vnet.ibm.com> <alpine.DEB.2.20.1710311832390.4581@digraph.polyomino.org.uk>
On 11/01/2017 12:04 AM, Joseph Myers wrote:
On Tue, 31 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:
2017-10-31 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
* sysdeps/ieee754/flt-32/s_sinf.c: New implementation.
Missing [BZ #5997] marker.
BZ#5997 reported sinf performance on x86_64 and sinf had
already been optimized for x86_64. The proposed patch is
generic version which now improves performance on other
arch. So I think 5997 can be marked as fixed.
+/* Chebyshev constants for sin, range -PI/4 - PI/4. */
I presume some of these are actually for cos and so there should be more
detailed comments for the separate groups of constants.
Ack.
+static inline float
+reduced (const double theta, const unsigned long n,
+ const unsigned long signbit)
This function needs a comment above it explaining the semantics of the
arguments and the return value.
+float
+SINF_FUNC(float x)
Missing space before '('.
Ack. Will send an updated patch.
--
Thanks
Rajalakshmi S