This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2] New generic sinf
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Rajalakshmi Srinivasaraghavan <raji at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 31 Oct 2017 18:34:54 +0000
- Subject: Re: [PATCHv2] New generic sinf
- Authentication-results: sourceware.org; auth=none
- References: <1509436736-23436-1-git-send-email-raji@linux.vnet.ibm.com>
On Tue, 31 Oct 2017, Rajalakshmi Srinivasaraghavan wrote:
> 2017-10-31 Rajalakshmi Srinivasaraghavan <raji@linux.vnet.ibm.com>
>
> * sysdeps/ieee754/flt-32/s_sinf.c: New implementation.
Missing [BZ #5997] marker.
> +/* Chebyshev constants for sin, range -PI/4 - PI/4. */
I presume some of these are actually for cos and so there should be more
detailed comments for the separate groups of constants.
> +static inline float
> +reduced (const double theta, const unsigned long n,
> + const unsigned long signbit)
This function needs a comment above it explaining the semantics of the
arguments and the return value.
> +float
> +SINF_FUNC(float x)
Missing space before '('.
--
Joseph S. Myers
joseph@codesourcery.com