Re: [PATCH] Reformat sysdeps/x86/libc-start.c

[Jonathan Nieder <jrnieder at gmail dot com>]

Hi,

Carlos O'Donell wrote:

> Should we extend consensus?
>
> https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes
> ~~~
> Anyone can commit a change fixing obvious coding standards problems
> in a recently committed patch. Post the patch and ChangeLog to
> libc-alpha with a short message and then push the commit. 
> ~~~
> s/a recently/any/g
>
> We normally allow this kind of change for "recently committed"
> patches, but shy away from it for older changes because of the impact
> it might ave on established code.
>
> In this case I would have liked HJ to be able to just push the cleanup
> without anyone *needing* to do a pre-commit review.

I would rather not --- getting LGTM is a pretty lightweight action,
and in other projects when I thought I had a good cleanup, getting
review pushed me in another direction that caused an even better
result.

I'd rather not see glibc switching to post-push review for most
commits and pre-push review as an exception.  Instead, how can I help
with making pre-push review work better?

E.g. if obvious patches are stalling without review, can we figure out
why and get that problem solved?  (E.g. do we need something like
patchwork to keep track of patches needing review?)

Thanks,
Jonathan