Re: [PATCH] Assume that _DIRENT_HAVE_D_TYPE is always defined.

[Carlos O'Donell <carlos at redhat dot com>]

On 10/30/2017 07:46 AM, Florian Weimer wrote:
>> Our shared source file list says this comes from 'gnulib': 
>> https://sourceware.org/glibc/wiki/SharedSourceFiles
>> 
>> Are we able to harmonize this with gnulib?
> 
> Not sure if this is a good idea.  We use the generic code as a
> building block for the Linux implementation, and I doubt the gnulib
> implementation will support such abuse.

We have two high-level options:

(a) Approach gnulib with a patch that removes the conditional on
    _DIRENT_HAVE_D_TYPE, and make the case.

(b) Stop sharing this source file with gnulib, update the SharedSourceFiles
    not to list the file. Provide a comment in the file stating all of the
    historical details and why we are not sharing anymore.

You could do (a) today, there is consensus for that.

I think (b) needs a distinct discussion in a new thread to gather input.

I leave it up to you to go down either path as you think appropriate.

I'm on the fence. The getcwd.c implementation isn't so complex that we
can't just have our own copy, but at the same time, any meaningful
deviation from gnulib seems spurious. Therefore I think there is slightly
more inertia for trying to stay harmonized with gnulib.

-- 
Cheers,
Carlos.