This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid warnings
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Fri, 27 Oct 2017 15:20:34 +0100
- Subject: Re: [PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid warnings
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <59EF4CEC.8020301@arm.com> <59EF4D34.4020506@arm.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 24/10/17 15:24, Szabolcs Nagy wrote:
> From 74f8c71fee285657860926c8e45227041265d15d Mon Sep 17 00:00:00 2001
> From: Szabolcs Nagy <szabolcs.nagy@arm.com>
> Date: Mon, 23 Oct 2017 12:15:40 +0100
> Subject: [PATCH 1/7] Mark lazy tlsdesc helper functions unused to avoid
> warnings
>
> These static functions are not needed if a target does not do lazy
> tlsdesc initialization.
>
> 2017-10-23 Szabolcs Nagy <szabolcs.nagy@arm.com>
>
> * elf/tlsdeschtab.h (_dl_tls_resolve_early_return_p): Mark unused.
> (_dl_tlsdesc_wake_up_held_fixups): Likewise.
i'd like to get consensus on this (trivial) change.
once it's committed, other targets (i386, x86_64) can
also remove lazy tlsdesc code.
after that these functions can be completely removed.
> ---
> elf/tlsdeschtab.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/elf/tlsdeschtab.h b/elf/tlsdeschtab.h
> index ad3001dac5..879631897c 100644
> --- a/elf/tlsdeschtab.h
> +++ b/elf/tlsdeschtab.h
> @@ -137,6 +137,7 @@ _dl_make_tlsdesc_dynamic (struct link_map *map, size_t ti_offset)
> avoid introducing such dependencies. */
>
> static int
> +__attribute__ ((unused))
> _dl_tlsdesc_resolve_early_return_p (struct tlsdesc volatile *td, void *caller)
> {
> if (caller != atomic_load_relaxed (&td->entry))
> @@ -155,6 +156,7 @@ _dl_tlsdesc_resolve_early_return_p (struct tlsdesc volatile *td, void *caller)
> }
>
> static void
> +__attribute__ ((unused))
> _dl_tlsdesc_wake_up_held_fixups (void)
> {
> __rtld_lock_unlock_recursive (GL(dl_load_lock));
> -- 2.11.0
>