This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.


On 10/25/2017 03:03 AM, Rafal Luzynski wrote:
> 24.10.2017 00:33 Carlos O'Donell <carlos@redhat.com> wrote:
>> On 10/23/2017 03:21 AM, Rafal Luzynski wrote:
>>> I will appreciate if you fix these problem on your own, the last problem
>>> at least.
>>
>> I will fix this immediately and commit the changes. Thank you again for the
>> review.
> 
> I can't see your commit. Please do these changes or ask other people
> (including me, of course).

Committed. Just needed to test a few more things. My apologies for the delay.

I'm happy to review any patches that fix mistakes I've made, please don't
feel that you need to wait for me either. As a subsystem maintainer you can
post a patch with "[committed]" status that fixes my mistakes, and you may
do so immediately :-)

commit 337ff3c501f0e1fadd1036b6fa2754cfbb0c29ea
Author: Carlos O'Donell <carlos@systemhalted.org>
Date:   Wed Oct 25 09:06:45 2017 -0700

    localedata: Fix unicode-gen check target.
    
    After the transition to generating a distinct file for Unicode ctype
    information e.g. i18n_ctype, the check target was left with the wrong
    target name. This patch fixes the check target and regenerates the
    files with more information than previously used, filling in the the
    LC_IDENTIFICATION data.
    
    Tested on x86_64 by regenerating from Unicode source files, and
    running checks. Tested by subsequently rebuilding all locales.
    No regressions in testsuite.
    
    Signed-off-by: Carlos O'Donell <carlos@redhat.com>
    Reported-by: Rafal Luzynski <digitalfreak@lingonborough.com>

-- 
Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]