This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH v9 0/6][BZ 10871] Month names in alternative grammatical case
11.10.2017 19:47 Zack Weinberg <zackw@panix.com> wrote:
>
>
> On Tue, Oct 10, 2017 at 6:30 AM, Rafal Luzynski
> <digitalfreak@lingonborough.com> wrote:
> > 3.10.2017 01:43 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> >> 26.09.2017 12:45 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
> >> >
> >> > Ping - anyone?
>
> I plan to review this carefully, and perhaps go ahead and merge it,
> next week if no one else gets to it first.
>
> zw
I'm not sure if I understood you correctly. Should I wait for your
review and then go ahead and merge? Then here is my ping. Or maybe
did you mean that I should go ahead and merge even if you don't have
time to review? In this case I'd rather not merge without another
review because at least two things are not clear to me:
1. You asked me to write a documentation but I'm not sure which
documentation you meant. I updated NEWS, ChangeLog and some files
in the manual directory. But I'm not sure if this is sufficient, also
I'd like to see at least one review.
2. You asked me not to send the generated file locfile-kw.h to this list [2]
so I have not sent it anymore. But this file still needs to be pushed
to git. The patches are still available in bugzilla [3] and my github
repo. [4] Should I merge them after the review and before pushing to master?
BTW, I have updated my github repo but not other places where these
patches are stored (bugzilla, Fedora COPR, this list). With the glibc
development moving fast forward it's difficult to keep the patches up-to-date.
Regards,
Rafal
[1] https://sourceware.org/ml/libc-alpha/2017-07/msg00031.html
[2] https://sourceware.org/ml/libc-alpha/2017-07/msg00032.html
[3] https://sourceware.org/bugzilla/show_bug.cgi?id=10871
[4] https://github.com/rluzynski/glibc