This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] localedata: Reorganize Unicode LC_CTYPE inclusion.
24.10.2017 00:33 Carlos O'Donell <carlos@redhat.com> wrote:
> On 10/23/2017 03:21 AM, Rafal Luzynski wrote:
> [...]
> > 13.10.2017 08:49 Carlos O'Donell <carlos@redhat.com> wrote:
> >>
> >> [...]
> >> (i18n-report): Rename to...
> >> (i18n_ctype-report): ...this.
> >
> > Was this change intentional? [...]
>
> It was intentional.
Fair enough.
> [...]
> Please feel free to adjust the file accordingly.
Do you want me to regenerate the file and push it to master?
But it's reasonable to fix the Makefile before which you have
decided to fix already (see below).
> Something like this?
>
> diff --git a/localedata/locales/i18n_ctype b/localedata/locales/i18n_ctype
> index da88efc..a4ecc65 100644
> --- a/localedata/locales/i18n_ctype
> +++ b/localedata/locales/i18n_ctype
> @@ -8,37 +8,26 @@ comment_char %
> % exempt you from the conditions of the license if your use would
> % otherwise be governed by that license.
>
> -%
> % The only purpose for this file is to provide the basic Unicode
> % LC_CTYPE information. This way other locales that need this
> % information, but with different transliterations, can include it
> % directly.
> -%
I haven't got this part either so it would be fully removed as well.
The file starts with:
escape_char /
comment_char %
% Generated automatically by gen_unicode_ctype.py for Unicode 10.0.0.
Of course we can leave this part if it is necessary.
> -LC_IDENTIFICATION
> -title ""
> -source ""
> -address ""
> -contact ""
> -email ""
> -tel ""
> -fax ""
> -language ""
> -territory ""
> -revision ""
> -date "2017-10-11"
> +% Generated automatically by gen_unicode_ctype.py for Unicode 10.0.0.
>
> -category "i18n:2012";LC_IDENTIFICATION
> -category "i18n:2012";LC_CTYPE
> -category "i18n:2012";LC_COLLATE
> -category "i18n:2012";LC_TIME
> -category "i18n:2012";LC_NUMERIC
> -category "i18n:2012";LC_MONETARY
> -category "i18n:2012";LC_MESSAGES
> -category "i18n:2012";LC_PAPER
> -category "i18n:2012";LC_NAME
> -category "i18n:2012";LC_ADDRESS
> -category "i18n:2012";LC_TELEPHONE
> +LC_IDENTIFICATION
> +title "Unicode 10.0.0 FDCC-set"
> +source "UnicodeData.txt, DerivedCoreProperties.txt"
> +address ""
> +contact ""
> +email "bug-glibc-locales@gnu.org"
> +tel ""
> +fax ""
> +language ""
> +territory "Earth"
> +revision "10.0.0"
> +date "2017-10-23"
> +category "unicode:2014";LC_CTYPE
> END LC_IDENTIFICATION
>
> LC_CTYPE
> ---
>
> Looks good to me.
Otherwise looks good to me as well although I have not checked bit by bit
(and my mail client must have eaten some spaces.)
> [...]
> >>
> >> all: $(GENERATED)
> >>
> >> -check: check-i18n check-UTF-8
> >> +check: check-i18n_ctype check-UTF-8
> >
> > Here is the major problem: either you should consequently change
> > check-i18n to check-i18n_ctype everywhere or not change it at all.
> > Look below:
>
> Thank you for spotting this!
>
> >> check-i18n: i18n-report
> >> @if grep '\(Missing\|Added\) [^0]\|^Number of errors[^=]* = [^0]' \
> >> --
> >> 2.7.5
> >
> > here check-i18n is not changed. As a result, `make check' fails:
> >
> > $ make check
> > make: *** No rule to make target 'check-i18n_ctype', needed by 'check'.
> > Stop.
> >
> > I will appreciate if you fix these problem on your own, the last problem
> > at least.
>
> I will fix this immediately and commit the changes. Thank you again for the
> review.
I can't see your commit. Please do these changes or ask other people
(including me, of course).
Regards,
Rafal