This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 02/10] i386: Replace assembly versions of e_expf with generic e_expf.c

From: Joseph Myers <joseph at codesourcery dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: <libc-alpha at sourceware dot org>
Date: Thu, 19 Oct 2017 17:44:09 +0000
Subject: Re: [PATCH 02/10] i386: Replace assembly versions of e_expf with generic e_expf.c
Authentication-results: sourceware.org; auth=none
References: <20171019173159.21402-1-hjl.tools@gmail.com> <20171019173159.21402-3-hjl.tools@gmail.com>

I think there should also be --disable-multi-arch benchmark results here.  
Likewise for other i386 functions in this series (as otherwise all of the 
x86 benchmarks you give are testing the multiarch/*-sse2.c case only, 
nothing is testing the generic fallback of the C version built to use x87 
arithmetic - which I expect is still very likely to be faster than the old 
.S implementation, and you might justify removing the .S versions even if 
the .c versions built for x87 aren't faster, but benchmark results for 
that case should still be given).

-- 
Joseph S. Myers
joseph@codesourcery.com

Follow-Ups:
- Re: [PATCH 02/10] i386: Replace assembly versions of e_expf with generic e_expf.c
  - From: H.J. Lu

References:
- [PATCH 00/10] x86: Use the generic math implementations
  - From: H.J. Lu
- [PATCH 02/10] i386: Replace assembly versions of e_expf with generic e_expf.c
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]