This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] locale: Fix localedef exit code [BZ #22292]
On 10/16/2017 12:24 AM, Florian Weimer wrote:
> On 10/15/2017 11:19 PM, Carlos O'Donell wrote:
>> (b) Do not make ASCII compatibility a warning. See the large
>> comment in locale/programs/charmap.c line ~205. It would appear
>> that the SHIFT_JIS* charmaps violate this ISO C requirement, which
>> could cause problems for some programs, thus the warning (in
>> localedata/gen-locale.sh I work around this for SHIFT_SJIS for
>> testing shift charmaps).
>
> Running a system with Shift JIS may introduce security
> vulnerabilities because parts of the system will disagree where
> string literals end, due different interpretations of the 0x5c
> codepoint.
>
> I think we should add a command line argument to localedef which
> turns off returning exit status 1 for locales which are not
> ASCII-compatible.
Done. I'll work that up and post a patch.
--
Cheers,
Carlos.