This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 4/5] Fix deadlock in _int_free consistency check


On 10/12/2017 12:16 PM, Andreas Schwab wrote:
On Okt 12 2017, Florian Weimer <fweimer@redhat.com> wrote:

On 10/12/2017 11:35 AM, Wilco Dijkstra wrote:
This patch fixes a deadlock in the fastbin consistency check.
If we fail the fast check due to concurrent modifications to
the next chunk or system_mem, we should not lock if we already
have the arena lock.  Simplify the check to make it obviously
correct.

I don't think the subject line is correct.  What is the deadlock?  I don't
see it.

The problem is that commit 24cffce736 inverted the condition on
have_lock, which is wrong.

Oh, right, sorry about that.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]