This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Linux: Consolidate {RTLD_}SINGLE_THREAD_P definition
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Tue, 10 Oct 2017 17:39:12 -0300
- Subject: Re: [PATCH 2/3] Linux: Consolidate {RTLD_}SINGLE_THREAD_P definition
- Authentication-results: sourceware.org; auth=none
- References: <1502140314-16598-1-git-send-email-adhemerval.zanella@linaro.org> <1502140314-16598-2-git-send-email-adhemerval.zanella@linaro.org> <560cb30c-5c21-a269-e650-4919267c3faa@redhat.com> <626d5dbc-07d4-cf15-a7a6-9615b2ed9daf@linaro.org>
On 08/08/2017 08:59, Adhemerval Zanella wrote:
>
>
> On 08/08/2017 03:18, Florian Weimer wrote:
>> On 08/07/2017 11:11 PM, Adhemerval Zanella wrote:
>>> * sysdeps/unix/sysv/linux/x86_64/sysdep.h (SINGLE_THREAD_BY_GLOBAL):
>>> Likewise.
>>
>> Is this correct? Should it be guarded by IS_IN (libc)?
>>
>> Thanks,
>> Florian
>>
>
> SINGLE_THREAD_BY_GLOBAL is already used guarded with IS_IN (libc)
> for the cases where the code is build on both libc and libpthread:
>
> nptl/libc_multiple_threads.c:21:#if IS_IN (libc) && defined (SINGLE_THREAD_BY_GLOBAL)
> nptl/vars.c:38:#if IS_IN (libpthread) && defined (SINGLE_THREAD_BY_GLOBAL)
>
If noone objects I will commit it.