This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][BZ #21326] Ensure C99 and C11 interfaces are available for C++


On 09/10/17 16:02 +0200, Florian Weimer wrote:
On 10/09/2017 04:00 PM, Jonathan Wakely wrote:

I think there is a preexisting issue here which will trigger macro redefinition warnings with -Wsystem-headers.  But perhaps I'm mistaken.

Even though both definitions are identical?

I think there's no redefinition warning for:

#define __USE_ISOC99 1
#define __USE_ISOC99 1

Only if the macro's replacement-list differs on the redefinition.

Oh, I didn't know that.  Thanks.

Apart from that, the substance of the patch looks okay to me.

Thanks. Here's an updated patch against current master, with the fixed
indentation.

This version looks good to me. Can you install this yourself, or shall I install it for you?

I don't have commit access, so would be grateful if you can do it.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]