This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] nscd: Eliminate compilation time dependency in the build output
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
- Date: Thu, 5 Oct 2017 09:13:52 -0700
- Subject: Re: [PATCH] nscd: Eliminate compilation time dependency in the build output
- Authentication-results: sourceware.org; auth=none
- References: <20171005144957.6383142022590@oldenburg.str.redhat.com>
On 10/05/2017 07:49 AM, Florian Weimer wrote:
> 2017-10-05 Florian Weimer <fweimer@redhat.com>
>
> nscd: Eliminate compilation time dependency in the build output.
> * nscd/nscd_stat.c (STATDATA_VERSION)
> (STATDATA_VERSION_SELINUX_FLAG, STATDATA_VERSION_FLAGS)
> (STATDATA_VERSION_FULL): New macro definitions.
> (compilation): Remove.
> (struct statdata): Adjust version member.
> (send_stats): Set version from STATDATA_VERSION_FULL.
> (receive_print_stats): Verify version against STATDATA_VERSION_FULL.
Looks good to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.