This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Always do locking when iterating over list of streams (bug 15142)
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org, Carlos O'Donell <carlos at redhat dot com>
- Date: Thu, 05 Oct 2017 16:51:13 +0200
- Subject: Re: [PATCH] Always do locking when iterating over list of streams (bug 15142)
- Authentication-results: sourceware.org; auth=none
- References: <20170817133507.CEA5341DB79B0@oldenburg.str.redhat.com> <mvmr2wap8sw.fsf@suse.de> <af6435dd-53c8-6f12-918f-37155a1ea192@redhat.com> <mvmmv6yp7tn.fsf@suse.de> <d76de696-721e-8fd2-ed80-648feaf6c38b@redhat.com> <mvminhhpeo0.fsf@suse.de> <b7e2d8d9-288f-5821-e31e-5fe45d337fc9@redhat.com> <mvm378lpaah.fsf@suse.de> <07ffdd4d-3bef-6371-2790-de3979ce22a1@redhat.com> <mvmy3qdntsl.fsf@suse.de> <mvmr2w5ngox.fsf_-_@suse.de> <70f5173f-1738-970f-27c1-3563c12a9157@redhat.com>
On Aug 21 2017, Florian Weimer <fweimer@redhat.com> wrote:
> On 08/21/2017 04:22 PM, Andreas Schwab wrote:
>> [BZ #15142]
>> * libio/genops.c (_IO_list_all_stamp): Delete. All uses removed.
>> (_IO_flush_all_lockp): Always lock list_all_lock.
>> (_IO_flush_all_linebuffered): Likewise.
>> (_IO_unbuffer_all): Likewise.
>
> This change seems reasonable, but I think we need to remove flushing on
> abort first (completely, not the hybrid attempt I posted).
Now that flushing is removed from abort, ok?
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."