This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files

From: Florian Weimer <fweimer at redhat dot com>
To: GLIBC Devel <libc-alpha at sourceware dot org>
Date: Wed, 4 Oct 2017 15:17:43 +0200
Subject: Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com CED8AC03E7A5
References: <1464696577.24965.16.camel@trentalancia.net> <1464698125.24965.18.camel@trentalancia.net> <1464717048.2379.43.camel@trentalancia.net> <1464722725.2379.62.camel@trentalancia.net>

On 05/31/2016 09:25 PM, Guido Trentalancia wrote:

When configuring and building GNU libc using the Mozilla NSS library
for cryptography (--enable-nss-crypt option), also include the
NSPR header files along with the Mozilla NSS library header files.

Finally, when running the check-local-headers test, ignore the
Mozilla NSPR library header files (used by the Mozilla NSS library)
as otherwise false positives (FAIL) are obtained.

2016-05-31  Guido Trentalancia<guido@trentalancia.net>

	[BZ #17956]
	* configure: If the Mozilla NSS library is used for
	cryptography (--enable-nss-crypt option), also include
	the Mozilla NSPR header files when building the test
	program. Fail if Mozilla NSPR cannot be found.

	* configure.ac: Likewise.

	* crypt/Makefile: Include the Mozilla NSPR header files
	when the Mozilla NSS library is used for cryptography
	(--enable-nss-crypt configure option).

	* scripts/check-local-headers.sh: Ignore the Mozilla NSPR header
	files.

I was finally able to verify this change and pushed it, with a minorcrypt/Makefile tweak and a slightly reworded ChangeLog.


Thanks,
Florian

Follow-Ups:
- Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files
  - From: Rafal Luzynski

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]