This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/58] Mark internal functions with attribute_hidden [BZ #18822]
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: libc-alpha at sourceware dot org
- Date: Sun, 1 Oct 2017 14:37:33 -0700
- Subject: Re: [PATCH 01/58] Mark internal functions with attribute_hidden [BZ #18822]
- Authentication-results: sourceware.org; auth=none
- References: <20170901180029.9527-1-hjl.tools@gmail.com> <20170901180029.9527-2-hjl.tools@gmail.com>
On 9/1/17, H.J. Lu <hjl.tools@gmail.com> wrote:
> Mark internal functions with attribute_hidden to allow direct access to
> internal functions within libc.so and libc.a without using GOT nor PLT.
>
> Size comparison of libc.so:
>
> On x86-64:
> text data bss dec hex
> Before: 1728577 20584 17088 1766249 1af369
> After : 1728593 20584 17088 1766265 1af379
>
> The only change is __gconv_release_shlib in iconv/gconv_dl.c is inlined
> since it is hidden, which increases the code size of gconv_dl.os by 18
> bytes.
>
> On i686:
> text data bss dec hex
> Before: 1869039 11444 11112 1891595 1cdd0b
> After : 1868635 11444 11112 1891191 1cdb77
>
> The code size is decreased by avoiding GOT/PLT for hidden functions.
>
> [BZ #18822]
> * iconv/gconv_int.h (__gconv_open): Add attribute_hidden.
> (__gconv_close): Likewise.
> (__gconv): Likewise.
> (__gconv_find_transform): Likewise.
> (__gconv_lookup_cache): Likewise.
> (__gconv_compare_alias_cache): Likewise.
> (__gconv_load_cache): Likewise.
> (__gconv_get_path): Likewise.
> (__gconv_close_transform): Likewise.
> (__gconv_release_cache): Likewise.
> (__gconv_find_shlib): Likewise.
> (__gconv_release_shlib): Likewise.
> (__gconv_get_builtin_trans): Likewise.
> (__gconv_compare_alias): Likewise.
> * include/dlfcn.h (_dlerror_run): Likewise.
> * include/stdio.h (__fortify_fail_abort): Likewise.
> * include/time.h (__tz_compute): Likewise.
> (__strptime_internal): Likewise.
> * intl/gettextP.h (_nl_find_domain): Likewise.
> (_nl_load_domain): Likewise.
> (_nl_find_msg): Likewise.
> * intl/plural-exp.h (FREE_EXPRESSION): Likewise.
> (EXTRACT_PLURAL_EXPRESSION): Likewise.
> * locale/coll-lookup.h (__collidx_table_lookup): Likewise.
> * resolv/gai_misc.h (__gai_enqueue_request): Likewise.
> (__gai_find_request): Likewise.
> (__gai_remove_request): Likewise.
> (__gai_notify): Likewise.
> (__gai_notify_only): Likewise.
> * sysdeps/generic/aio_misc.h (__aio_sigqueue): Likewise.
> * sysdeps/generic/ldsodefs.h (_dl_fini): Likewise.
> (_dl_non_dynamic_init): Likewise.
> (_dl_aux_init): Likewise.
> * sysdeps/i386/machine-gmon.h (mcount_internal): Likewise.
> * sysdeps/unix/sysv/linux/i386/olddirent.h (__old_getdents64):
> Likewise.
> * wcsmbs/wcsmbsload.h (__wcsmbs_load_conv): Likewise.
> (__wcsmbs_clone_conv): Likewise.
> (__wcsmbs_named_conv): Likewise.
Tested with build-many-glibcs.py. I am checking it in.
--
H.J.