This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] Cleanup __ieee754_sqrt(f/l)
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, nd <nd at arm dot com>
- Date: Tue, 26 Sep 2017 17:30:57 +0000
- Subject: Re: [PATCH 2/3] Cleanup __ieee754_sqrt(f/l)
- Authentication-results: sourceware.org; auth=none
- References: <DB6PR0801MB20536B51BB0512DD67EEB156837B0@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Tue, 26 Sep 2017, Wilco Dijkstra wrote:
> Rename all calls to __ieee754_sqrt(f/l) to sqrt(f/l) to enable inlining
> by GCC.
What testing has been done for the float128 case, where sqrtl is mapped to
sqrtf128 by float128_private.h, and sqrtf128 is not inlined? The goal
there should be, I think, that sqrtf128 calls in libm get mapped by asm
name to __ieee754_sqrtf128. And there ought to be some way for powerpc
architecture maintainers to get __builtin_sqrtf128 used when building with
GCC 8 for hardware with a float128 sqrt instruction (but that's a matter
for the powerpc maintainers - as long as you draw their attention to the
issue, just making the patch ensure calls are mapped to __ieee754_sqrtf128
keeps things working as well as in the status quo).
--
Joseph S. Myers
joseph@codesourcery.com