This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: Perform full initialization before __malloc_check_init
- From: DJ Delorie <dj at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 26 Sep 2017 12:10:48 -0400
- Subject: Re: [PATCH] malloc: Perform full initialization before __malloc_check_init
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E9EADC057FA7
Florian Weimer <fweimer@redhat.com> writes:
> + /* Heap checking requires a valid top chunk, so perform full
> + initialization here. */
> + malloc_consolidate (&main_arena);
My original concern hasn't been addressed here, it's "tell the user why
malloc_consolidate() has anything to do with initialization".
s/here./here, which malloc_consolidate does/ is sufficient.