This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH] AArch64: use movz/movk instead of literal pools in start.S
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Boshi Wang <wangboshi at huawei dot com>
- Cc: nd at arm dot com, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 18 Sep 2017 18:21:24 +0100
- Subject: Re: [RFC][PATCH] AArch64: use movz/movk instead of literal pools in start.S
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Szabolcs dot Nagy at arm dot com;
- Nodisclaimer: True
- References: <e65025af-5168-c999-bfc1-7ac614314836@huawei.com> <59B65347.503@arm.com> <336560e5-c9de-08bc-c850-28994cac2c33@huawei.com> <59BA3F64.60504@arm.com> <2112d1ae-98b2-f555-99ed-99d1d24ac4da@huawei.com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On 15/09/17 02:16, Boshi Wang wrote:
> On 2017/9/14 16:35, Szabolcs Nagy wrote:
>> On 14/09/17 04:21, Boshi Wang wrote:
>>> On 2017/9/11 17:11, Szabolcs Nagy wrote:
>>>> On 07/09/17 08:33, wangboshi wrote:
>>>>> 2017-09-07 Wang Boshi <wangboshi@huawei.com>
>>>>>
>>>>> * sysdeps/aarch64/start.S: Use MOVL instead of literal pools.
>>>>> * sysdeps/aarch64/sysdep.h (MOVL): Add MOVL macro.
>>>>>
>>>> thanks, the patch looks good to me (except for a nit below),
>>>> do you have copyright assignment?
>>>> do you have commit rights to the glibc repo?
>>> I have read requirements of copyright assignment. I don't have that.
>>>
>>> I don't have commit rights, too.
>>>
>>> So how can I contribute the change? Could you give me some suggestions?
>>>
>> i think your change is just below the legally-significant limit
>> https://www.gnu.org/prep/maintain/maintain.html#Legally-Significant
>> so i can commit it for you.
>>
>> but getting your employer to sort it out with the fsf would be better,
>> in case you run into further issues that need glibc fixes.
>>
> That's great. I have a few doubt. Could you add my name into the patch?
> The new patch is here below.
>
committed.