This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/1] Add new codepage charmaps/IBM858


9.09.2017 11:43 Mike FABIAN <mfabian@redhat.com> wrote:
> [...]
> [BZ #21084]
> * benchtests/strcoll-inputs/filelist#en_US.UTF-8: Add IBM858 and ibm858.c.
> * iconvdata/Makefile: Add IBM858.
> * iconvdata/gconv-modules: Add IBM858.

I think there should be "Likewise." if there is the same comment in
multiple lines.

> * iconvdata/ibm858.c: New file.
> * iconvdata/tst-tables.sh: Add IBM858
> * localedata/charmaps/IBM858: New file.

Can we reorder the lines and use "Likewise." once again?

Just these nitpicks, otherwise no objections.

Regards,

Rafal


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]