This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 1/1] Add new codepage charmaps/IBM858

From: Florian Weimer <fweimer at redhat dot com>
To: Mike FABIAN <mfabian at redhat dot com>
Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
Date: Thu, 14 Sep 2017 11:10:33 +0200
Subject: Re: [PATCH v2 1/1] Add new codepage charmaps/IBM858
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 84F075D5EA
References: <s9defrhzhuh.fsf@redhat.com> <alpine.DEB.2.20.1709081612320.16313@digraph.polyomino.org.uk> <s9dings8axh.fsf_-_@redhat.com>

On 09/09/2017 11:43 AM, Mike FABIAN wrote:

Subject: [PATCH] Add new codepage charmaps/IBM858

	[BZ #21084]
	* benchtests/strcoll-inputs/filelist#en_US.UTF-8: Add IBM858 and ibm858.c.
	* iconvdata/Makefile: Add IBM858.
	* iconvdata/gconv-modules: Add IBM858.
	* iconvdata/ibm858.c: New file.
	* iconvdata/tst-tables.sh: Add IBM858
	* localedata/charmaps/IBM858: New file.

Patch looks good. Thanks for adding the comment about the discrepancybetween our ASCII-compatible version and IBM's specification.

Please commit this with [BZ #21084] on the first line of the commitmessage. Perhaps also mention the ASCII/IBM discrepancy in the commitmessage.


Thanks,
Florian

References:
- [PATCH 1/1] Add new codepage charmaps/IBM858
  - From: Mike FABIAN
- Re: [PATCH 1/1] Add new codepage charmaps/IBM858
  - From: Joseph Myers
- [PATCH v2 1/1] Add new codepage charmaps/IBM858
  - From: Mike FABIAN

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]