This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 08/58] Mark __dso_handle as hidden [BZ #18822]


On Mon, Sep 4, 2017 at 2:19 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Sep 4, 2017 at 12:22 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 09/03/2017 03:42 PM, H.J. Lu wrote:
>>> On Sun, Sep 3, 2017 at 2:11 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>>> On 09/03/2017 10:21 AM, Florian Weimer wrote:
>>>>> On 09/01/2017 07:59 PM, H.J. Lu wrote:
>>>>>> diff --git a/include/stdlib.h b/include/stdlib.h
>>>>>> index 2274790a2e..d0dcbf81c3 100644
>>>>>> --- a/include/stdlib.h
>>>>>> +++ b/include/stdlib.h
>>>>>> @@ -5,6 +5,10 @@
>>>>>>  #endif
>>>>>>  #include <stdlib/stdlib.h>
>>>>>>
>>>>>> +/* __dso_handle is always defined by either crtbegin.o from GCC or our
>>>>>> +   dso_handle.c.  */
>>>>>> +extern void *__dso_handle __attribute__ ((visibility ("hidden")));
>>>>>
>>>>> This causes conform test failures.  You need to use __visibility__ here.
>>
>>>> Or alternatively, move the declaration under #ifndef _ISOMAC.  That's
>>>> probably the better approach because __dso_handle is not part of the
>>>> installed headers.
>>>>
>>>
>>> No, we can't do that.  Some tests reference __dso_handle and _ISOMAC
>>> isn't defined for tests.
>>
>> These tests should be moved to tests-internal, or __dso_handle should be
>
> We may not define _ISOMAC for these tests since it may introduce
> many issues.
>
>> declared in a different header and the tests should include it.
>
> Here is an updated with include/dso_handle.h.  OK for master?
>
> Thanks.
>

Any comments or objections?

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]