This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings
- From: Steve Ellcey <sellcey at cavium dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Joseph Myers <joseph at codesourcery dot com>, DJ Delorie <dj at redhat dot com>, libc-alpha at sourceware dot org
- Date: Mon, 11 Sep 2017 13:01:46 -0700
- Subject: Re: [PATCH] Remove compat from DEFAULT_CONFIG lookup strings
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <xntw0z9urp.fsf@greed.delorie.com> <1503951778.28672.139.camel@cavium.com> <alpine.DEB.2.20.1708282042270.13583@digraph.polyomino.org.uk> <1503957036.28672.144.camel@cavium.com> <alpine.DEB.2.20.1708282256280.13583@digraph.polyomino.org.uk> <1504033460.5204.8.camel@cavium.com> <mvmwp5kgq3r.fsf@suse.de> <1504193091.3182.8.camel@cavium.com>
- Reply-to: sellcey at cavium dot com
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Ping. Any other comments on the last version of this patch?
Does it look OK to check in?
Steve Ellcey
sellcey@cavium.com
On Thu, 2017-08-31 at 08:24 -0700, Steve Ellcey wrote:
> On Thu, 2017-08-31 at 09:20 +0200, Andreas Schwab wrote:
> >
> >
> > >
> > > +#ifdef LINK_OBSOLETE_RPC
> > > +# define DEFAULT_DEFCONFIG "nis [NOTFOUND=return] files"
> > > +#else
> > > +# define DEFAULT_DEFCONFIG "files"
> > > +#endif
> > nss_nis is part of obsolete-nsl, not obsolete-rpc.
> >
> > Andreas.
> Yes it is. Here is an updated patch with that change.
>
> Steve Ellcey
> sellcey@cavium.com
>
> 2017-08-31 Steve Ellcey <sellcey@cavium.com>
>
> * grp/initgroups.c: Include config.h.
> (DEFAULT_CONFIG): New macro.
> (internal_getgrouplist): Use DEFAULT_CONFIG.
> * nscd/initgrcache.c (addinitgroupsX): Likewise.
> * nss/nsswitch.c (__nss_disable_nscd): Likewise.
> (DEFAULT_DEFCONFIG): New macro.
> (__nss_database_lookup): Use DEFAULT_DEFCONFIG.
> * nss/grp-lookup.c: Include config.h
> (DEFAULT_CONFIG): Set definition based on LINK_OBSOLETE_NSL.
> * nss/pwd-lookup.c (DEFAULT_CONFIG): Likewise.
> * nss/spwd-lookup.c (DEFAULT_CONFIG): Likewise.
> * manual/nss.texi: Update default values section.
>