This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3] powerpc: Add redirection for finitef128, isinf128, and isnanf128
On Fri, 8 Sep 2017, Gabriel F. T. Gomes wrote:
> On top of that, math/math.h includes bits/mathcalls-helper-functions.h
> (once for each floating-point type). However, the declarations in
> bits/mathcalls-helper-functions.h are macroized using __MATHDECL_1.
> __MATHDECL_1 receives the suffix (f, l, f128, or nothing) as a parameter
> and expands the base name (e.g.: __finite).
>
> When s_finite.c defines __finite as __redirect_finite, all declarations in
> bits/mathcalls-helper-functions.h are also redefined. That doesn't happen
> with s_finitef.c because it only defines __finitef, which does not match
> with anything in bits/mathcalls-helper-functions.h.
I think that this key point - that the function name gets macro expanded
before the concatenation - needs explaining in comments in all three
affected source files to justify why they are defining the macros for
other types.
--
Joseph S. Myers
joseph@codesourcery.com