This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Removing ChangeLog [Was Re: 2.26 hard freeze status]
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Zack Weinberg <zackw at panix dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 4 Sep 2017 11:10:34 +0530
- Subject: Re: Removing ChangeLog [Was Re: 2.26 hard freeze status]
- Authentication-results: sourceware.org; auth=none
- References: <0e63a6a7-9367-e95e-84dd-87f738d3fd34@sourceware.org> <90f61129-0470-3ccb-4970-f662a99bbe4c@gotplt.org> <6307b029-5236-41e8-bcae-3dea55a22ccf@redhat.com> <b59ed47c-9fea-0b6b-b26a-4f37d57da7eb@gotplt.org> <1501229614.30433.83.camel@redhat.com> <d198726f-8895-0230-afc4-6b8fd3dd3b18@redhat.com> <95d5e703-9d62-29bc-2ee6-546e1df9db7e@gotplt.org> <CAKCAbMihLHdwL-Yk5O2WAOKJBYFdO5uN+CAFTMrbRskJ84cQeg@mail.gmail.com> <a4340963-e6ef-332b-bf44-fd1960866fe9@gotplt.org> <alpine.DEB.2.20.1708021524290.24686@digraph.polyomino.org.uk> <a24aca38-81d1-95a1-7eba-639a1dc67352@gotplt.org> <CAKCAbMjsf7m2aez_1Cz67MsaDOov1Koc8mM48RyLKfF3gmyzhA@mail.gmail.com> <alpine.DEB.2.20.1708021804060.24686@digraph.polyomino.org.uk> <54fc2385-7d28-01e3-c5ac-770b4a7c5412@gotplt.org> <d6a159fa-2249-8fe4-444c-d2f9966f1a8e@panix.com> <CAMe9rOrQzVyNxnuW2xVJqFbBTyDuRjMUFjqZbC2siEwC4vOefg@mail.gmail.com> <CAMe9rOoG3Muq8q57iBU6PEfxsLaX61Vur_e=J8yQ9e_f=EO6PQ@mail.gmail.com>
On Friday 01 September 2017 10:52 PM, H.J. Lu wrote:
> I checked in this patch to update tst-regex.c/tst-regex2.c for old ChangeLog
> move.
>
>
<snip>
> /* Make the content of the file available in memory. */
> - file = "../ChangeLog.8";
> + file = "../ChangeLog.old/ChangeLog.8";
> fd = open (file, O_RDONLY);
> if (fd == -1)
> error (EXIT_FAILURE, errno, "cannot open %s", basename (file));
> diff --git a/posix/tst-regex2.c b/posix/tst-regex2.c
> index 0d82c2acdd..5e624cb5c2 100644
> --- a/posix/tst-regex2.c
> +++ b/posix/tst-regex2.c
> @@ -33,7 +33,7 @@ do_test (void)
> "((((((((((.?))))))))))((((((((((.?))))))))))((((((((((.?))))))))))"
> "((((((((((.?))))))))))Log\\.13" };
>
> - int fd = open ("../ChangeLog.14", O_RDONLY);
> + int fd = open ("../ChangeLog.old/ChangeLog.14", O_RDONLY);
> if (fd < 0)
> {
> printf ("Couldn't open ChangeLog.14: %m\n");
>
Instead, it might be cleaner to just copy those files to
tst-regex2-input.txt or similar. We will likely run into this issue
again in another 5 years when all of us have forgotten about this ghost
dependency.
Siddhesh