This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers
- From: Carlos O'Donell <carlos at redhat dot com>
- To: sellcey at cavium dot com, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Cc: nd at arm dot com
- Date: Fri, 1 Sep 2017 13:56:42 -0500
- Subject: Re: [PATCH][aarch64] Fix hwcap argument passed to ifunc resolvers
- Authentication-results: sourceware.org; auth=none
- References: <1504132534.3182.4.camel@cavium.com> <59A8291E.2060205@arm.com> <1504195926.3182.20.camel@cavium.com> <0a36b77d-d8b2-14cb-2ff3-2d61b206f856@redhat.com> <1504286544.3182.61.camel@cavium.com> <1504287041.3182.63.camel@cavium.com>
On 09/01/2017 12:30 PM, Steve Ellcey wrote:
> I think I found my problem, tunable_is_name returns true if it matches
> and false if it does not but the use of it
> in sysdeps/unix/sysv/linux/aarch64/cpu-features.c is:
>
> if (tunable_is_name (mcpu, cpu_list[i].name) == 0)
>
> It should just be:
>
> if (tunable_is_name (mcpu, cpu_list[i].name))
>
> I will send a patch for this once I have tested it.
Thanks. This code is quite new. I expect this was just an oversight of
using the new API.
--
Cheers,
Carlos.