This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: Use compat_symbol_reference in libmcheck [BZ #22050]


On Thu, 31 Aug 2017, Carlos O'Donell wrote:

> >> That's the exact purpose of compat_symbol_reference.  I think Carlos is
> >> objecting to its use for a *definition*.
> > 
> > Well, I used it for the definitions of matherr and _LIB_VERSION in my 
> > tests of those compat symbols, because it does exactly what's expected: 
> > makes the definitions in the tests refer to the same entity as the compat 
> > symbols in the shared libraries, rather than being completely independent 
> > entities as they would by default.
>  
> While it does what's expected, the macro API wasn't designed with that in
> mind was it? I am objecting to using a macro not designed for this
> purpose, and suggesting a new macro that makes the intent clear.

I think "reference" naturally covers both cases of making the symbol refer 
to the same entity in both places.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]