This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2 v4] openpty: close slave pty fd on error
- From: Andreas Schwab <schwab at suse dot de>
- To: Christian Brauner <christian dot brauner at ubuntu dot com>
- Cc: libc-alpha at sourceware dot org, stgraber at stgraber dot org, serge at hallyn dot com, fweimer at redhat dot com, joseph at codesourcery dot com
- Date: Tue, 29 Aug 2017 16:00:26 +0200
- Subject: Re: [PATCH 1/2 v4] openpty: close slave pty fd on error
- Authentication-results: sourceware.org; auth=none
- References: <a05d5603-c074-966d-f75e-cb268d0dc249@redhat.com> <20170829134515.9345-1-christian.brauner@ubuntu.com>
On Aug 29 2017, Christian Brauner <christian.brauner@ubuntu.com> wrote:
> @@ -129,12 +124,17 @@ openpty (int *amaster, int *aslave, char *name,
> if (name != NULL)
> strcpy (name, buf);
>
> + ret = 0;
> +
> + on_error:
> + close (master);
> +
> + if (slave != -1)
> + close(slave);
> +
You don't want to close the fds on success.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."