This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [hurd,commited] hurd: fix build with -fstack-protector-strong
Hello,
Joseph Myers, on lun. 28 août 2017 11:44:56 +0000, wrote:
> On Sun, 27 Aug 2017, Samuel Thibault wrote:
> > + * mach/Versions (GLIBC_2.4): Add __stack_chk_fail.
> > + * hurd/Versions (GLIBC_2.4): Add __stack_chk_fail.
>
> These changes look suspicious. debug/Versions already exports
> __stack_chk_fail from libc at version GLIBC_2.4, so I'd expect those new
> Versions entries to have no effect
Ok, I had misunderstood the use of the similar versions added above
(__mach_msg, __mach_msg_overwrite, etc. which are defined by mach
itself)
> (The missing semicolon at the end of the new Versions entries is also
> suspicious; at least, contrary to the syntax normally used in these
> files.)
Indeed. If only I could find time to make master working, I'd be able to
work with it instead of keeping a cumbersome flow of patches between 3
differents repos :/
Thanks for the checks,
Samuel