This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 09/27] arm64/sve: Signal frame and context structure definition
- From: Dave Martin <Dave dot Martin at arm dot com>
- To: Alex Bennée <alex dot bennee at linaro dot org>
- Cc: linux-arch at vger dot kernel dot org, libc-alpha at sourceware dot org, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, gdb at sourceware dot org, Yao Qi <Yao dot Qi at arm dot com>, Alan Hayward <alan dot hayward at arm dot com>, Will Deacon <will dot deacon at arm dot com>, Richard Sandiford <richard dot sandiford at arm dot com>, Catalin Marinas <catalin dot marinas at arm dot com>, kvmarm at lists dot cs dot columbia dot edu, linux-arm-kernel at lists dot infradead dot org
- Date: Tue, 22 Aug 2017 16:41:11 +0100
- Subject: Re: [PATCH 09/27] arm64/sve: Signal frame and context structure definition
- Authentication-results: sourceware.org; auth=none
- References: <1502280338-23002-1-git-send-email-Dave.Martin@arm.com> <1502280338-23002-10-git-send-email-Dave.Martin@arm.com> <87y3qb52ez.fsf@linaro.org> <20170822111705.GT6321@e103592.cambridge.arm.com> <87tw0z4sk2.fsf@linaro.org> <20170822142135.GU6321@e103592.cambridge.arm.com> <87shgj4pc7.fsf@linaro.org>
On Tue, Aug 22, 2017 at 04:03:20PM +0100, Alex Bennée wrote:
>
> Dave Martin <Dave.Martin@arm.com> writes:
>
> > On Tue, Aug 22, 2017 at 02:53:49PM +0100, Alex Bennée wrote:
[...]
> >> +
> >> +#define SVE_VQ_BITS 128 /* 128 bits in one quadword */
> >> +#define SVE_VQ_BYTES (SVE_VQ_BITS / 8)
> >> +
> >
> > I was trying to keep extraneous #defines to a minimum, since this is a
> > uapi header, and people may depend on anything defined here.
> >
> > I think SVE_VQ_BYTES is reasonable to have, and this allows us to
> > rewrite a few hard-coded 0x10s and 16s symbolically which is probably a
> > good idea -- I'll add this.
> >
> > SVE_VQ_BITS looks redundant to me though. It wouldn't be used for any
> > purpose other than defining SVE_VQ_BYTES.
>
> Yeah I was more concerned with getting rid of the magic 0x10's than
> showing exactly how many bits something is.
OK, I'll take SVE_VQ_BYTES and use it in the appropriate places.
There are a few 0x10s/16s in the series that can use this instead
of being open-coded.
Cheers
---Dave