This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] mips/o32: fix internal_syscall5/6/7
On Thu, 17 Aug 2017, Adhemerval Zanella wrote:
> My point is I think we should aim for compiler optimization safeness
> (to avoid code breakage over compiler defined default flags) and taking
> as base current approach to *avoid* VLA on GLIBC I do not think it is
> good approach to use it as a bridge to force GCC to generate the expected
> code.
I think the point that -Werror=alloca -Werror=vla would be desirable for
building glibc (if you don't have any variable-size stack allocations, you
don't need to worry about problems with unbounded stack allocations, which
are always bad, even given reliable stack checking, because of the
inability to report errors from them) is a good one about why to avoid
using the VLA approach.
--
Joseph S. Myers
joseph@codesourcery.com