This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/18] malloc: Add specialized dynarray for C strings

From: Pedro Alves <palves at redhat dot com>
To: Florian Weimer <fweimer at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
Date: Thu, 17 Aug 2017 15:48:31 +0100
Subject: Re: [PATCH 08/18] malloc: Add specialized dynarray for C strings
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves at redhat dot com
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 24A69800A8
References: <1502463044-4042-1-git-send-email-adhemerval.zanella@linaro.org> <1502463044-4042-9-git-send-email-adhemerval.zanella@linaro.org> <a6d5c2d7-9141-1c7c-ad35-a8bc65e03eaf@redhat.com>

On 08/17/2017 11:12 AM, Florian Weimer wrote:

> There is a lot of complexity in this code to maintain the invariant that
> the stored array is NUL-terminated.  It also means that the dynarray
> functions must not be used directly.
> 
> std::string in C++ has a c_str() method which adds the null termination
> on demand.  

Depends on what you mean by C++.  std::string::c_str() must not throw
and must be constant time since C++11.

Thanks,
Pedro Alves

References:
- [PATCH v2 00/18] posix: glob fixes and refactor
  - From: Adhemerval Zanella
- [PATCH 08/18] malloc: Add specialized dynarray for C strings
  - From: Adhemerval Zanella
- Re: [PATCH 08/18] malloc: Add specialized dynarray for C strings
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]