This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] _dl_init: Remove internal_function attribute
On Mon, Aug 14, 2017 at 5:39 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 08/14/2017 02:28 PM, H.J. Lu wrote:
>>> # Clear %ebp, so that even constructors have terminated backchain.\n\
>>> xorl %ebp, %ebp\n\
>
>> CFI adjustments are missing.
>
> The original code did not have any because we never unwind to this
> frame, as indicated by the zero %ebp value.
>
> I can add CFI annotations for completeness, but I'd consider that a
> separate change. It is also not quite clear to me what the canonical
> frame address for the startup function should be. We reach into the
> caller's stack frame, after all.
>
The patch is fine then.
Thanks.
--
H.J.