This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] NPTL: Remove internal_function from stack marking functions
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 13 Aug 2017 11:06:56 -0700
- Subject: Re: [PATCH] NPTL: Remove internal_function from stack marking functions
- Authentication-results: sourceware.org; auth=none
- References: <20170812120519.0C8FC4027587E@oldenburg.str.redhat.com>
On Sat, Aug 12, 2017 at 02:05:19PM +0200, Florian Weimer wrote:
> These are called across DSO boundaries and therefore should use
> the ABI calling convention.
>
> 2017-08-12 Florian Weimer <fweimer@redhat.com>
>
> * elf/dl-support.c (_dl_make_stack_executable_hook): Remove
> internal_function.
> * nptl/allocatestack.c (__make_stacks_executable): Likewise.
> * nptl/pthreadP.h (__make_stacks_executable): Likewise.
> * sysdeps/generic/ldsodefs.h (_rtld_global): Remove
> internal_function from _dl_make_stack_executable_hook member.
> (_dl_make_stack_executable): Remove internal_function.
> * sysdeps/mach/hurd/dl-execstack.c (_dl_make_stack_executable):
> Likewise.
> * sysdeps/unix/sysv/linux/dl-execstack.c
> (_dl_make_stack_executable): Likewise.
>
LGTM.
Thanks.
H.J.