This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] NSS: Do not use internal_function for functions with hidden aliases
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 13 Aug 2017 11:04:28 -0700
- Subject: Re: [PATCH] NSS: Do not use internal_function for functions with hidden aliases
- Authentication-results: sourceware.org; auth=none
- References: <20170812120515.647204027587E@oldenburg.str.redhat.com>
On Sat, Aug 12, 2017 at 02:05:15PM +0200, Florian Weimer wrote:
> Such functions are called across DSO boundaries and should not
> use a non-standard ABI.
>
> 2017-08-12 Florian Weimer <fweimer@redhat.com>
>
> * grp/grp-merge.h (__copy_grp, __merge_grp): Remove
> internal_function.
> * grp/grp-merge.c (__copy_grp, __merge_grp): Likewise.
> * inet/netgroup.h (__internal_setnetgrent)
> (__internal_endnetgrent,__internal_getnetgrent_r): Likewise.
> * inet/getnetgrent_r.c (__internal_setnetgrent)
> (__internal_endnetgrent,__internal_getnetgrent_r): Likewise.
> * nss/XXX-lookup.c (DB_LOOKUP_FCT, DB_COMPAT_FCT): Likewise.
> * nss/getXXbyYY_r.c (DB_LOOKUP_FCT): Likewise.
> * nss/getXXent_r.c (DB_LOOKUP_FCT): Likewise.
> * nss/nsswitch.h (db_lookup_function): Likewise.
>
LGTM.
Thanks.
H.J.