This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] manual: Update alloca and variable length array documentation
- From: Florian Weimer <fweimer at redhat dot com>
- To: Carlos O'Donell <carlos at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Aug 2017 15:28:07 +0200
- Subject: Re: [PATCH] manual: Update alloca and variable length array documentation
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D41EF6D861
- References: <63922f93-860a-249a-c14c-7efea3a3189b@redhat.com> <0794782b-c011-fdd8-4456-d2539af9456a@redhat.com>
On 08/11/2017 03:11 PM, Carlos O'Donell wrote:
> On 08/11/2017 05:53 AM, Florian Weimer wrote:
>> I'm resubmitting my old documentation patch (from early 2016) for
>> reconsideration.
>>
>> I reinstated the mention of GNU compiler compatibility for strdupa and
>> strndupa.
>
> Thanks for the updated reference to the previous conversation with Paul Eggert.
> I read that as a reference for this review.
>
> The changes look good to me, they are better than what we had before.
>
> At a high level we are removing the limitation about use in parameter lists,
> and adding warnings about security, all good to me.
What about this node name?
@c Node name preserved for backwards compatibility; the correct
@c terminology is ``variable length array''.
@node GNU C Variable-Size Arrays
@subsubsection ISO C Variable Length Arrays
@cindex variable length arrays
Should I change it, potentially invalidating hyperlinks?
The node name is quite visible even in the HTML version.
Thanks,
Florian