This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/1] Fix iso 3166.def for TIWAN
- From: AKHILESH KUMAR <akhilesh dot k at samsung dot com>
- To: Mike FABIAN <mfabian at redhat dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Mon, 31 Jul 2017 03:36:51 +0000
- Subject: Re: [PATCH 1/1] Fix iso 3166.def for TIWAN
- Authentication-results: sourceware.org; auth=none
- Cms-type: 105P
- Dlp-filter: Pass
- References: <s9dd18kedy4.fsf@redhat.com> <1501243954-46361-1-git-send-email-akhilesh.k@samsung.com> <CGME20170728121634epcas5p3db3df5730c42459ebe67d112f0a38c3f@epcms5p5>
- Reply-to: akhilesh dot k at samsung dot com
> > @@ -224,7 +224,7 @@ DEFINE_COUNTRY_CODE ("SWAZILAND", SZ, SWZ, 748)
> > DEFINE_COUNTRY_CODE ("SWEDEN", SE, SWE, 752)
> > DEFINE_COUNTRY_CODE ("SWITZERLAND", CH, CHE, 756)
> > DEFINE_COUNTRY_CODE ("SYRIAN ARAB REPUBLIC", SY, SYR, 760)
> > -DEFINE_COUNTRY_CODE ("TAIWAN, PROVINCE OF CHINA", TW, TWN, 158)
> > +DEFINE_COUNTRY_CODE ("TAIWAN (PROVINCE OF CHINA)", TW, TWN, 158)
>
> I don’t really see why that is an improvement.
This patch only make consistency
Like
DEFINE_COUNTRY_CODE ("SINT MAARTEN (DUTCH PART)", SX, SXM, 534)
DEFINE_COUNTRY_CODE ("SAINT MARTIN (FRENCH PART)", MF, MAF, 663)
Query:-
1- > looks some countries info are missing Like “KOSOVA” ?
2- > Also Fron 1997 Hong Kong a sovereign state for “China”
why country_num is different for “Hong Kong”, "China" and TAIWAN ?
Some is found for other countries
3- >I believe this data is taken from iso.org is it mandatory ?
> > DEFINE_COUNTRY_CODE ("TAJIKISTAN", TJ, TJK, 762)
> > DEFINE_COUNTRY_CODE ("TANZANIA, UNITED REPUBLIC OF", TZ, TZA, 834)
> > DEFINE_COUNTRY_CODE ("THAILAND", TH, THA, 764)