This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix for bz14333 -- race between atexit() and exit()

From: Torvald Riegel <triegel at redhat dot com>
To: Paul Pluzhnikov <ppluzhnikov at google dot com>
Cc: Andreas Schwab <schwab at suse dot de>, Joseph Myers <joseph at codesourcery dot com>, GLIBC Devel <libc-alpha at sourceware dot org>, Ricky Zhou <rickyz at google dot com>
Date: Wed, 19 Jul 2017 14:26:19 +0200
Subject: Re: [patch] Fix for bz14333 -- race between atexit() and exit()
Authentication-results: sourceware.org; auth=none
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=triegel at redhat dot com
Dkim-filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D56FB75724
Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D56FB75724
References: <CALoOobNCZqgvcLJhuJt5eSWseuTfHJ9oVsG9TpPvytyfzF56mg@mail.gmail.com> <alpine.DEB.2.20.1707111221040.845@digraph.polyomino.org.uk> <CALoOobMw+FNimtKqhO4cyayp8HGeGWO55veqKCD=fNoknreXkA@mail.gmail.com> <alpine.DEB.2.20.1707111900580.9395@digraph.polyomino.org.uk> <CALoOobOgwZx2K-FWFi5zmqjk4vfxB4B2+Bv6koou7Ks9WCT4Yw@mail.gmail.com> <mvmwp7d7i29.fsf@suse.de> <CALoOobMnZ=dE52uWT-PXSb+Sz8SRbjG7FKCmuG+kZ47db76PUg@mail.gmail.com>

On Thu, 2017-07-13 at 10:45 -0700, Paul Pluzhnikov wrote:
> On Wed, Jul 12, 2017 at 9:09 AM, Andreas Schwab <schwab@suse.de> wrote:
> >
> > On Jul 12 2017, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> >
> > > +extern int __exit_funcs_done attribute_hidden;
> >
> > That should be bool.
> 
> 
> Thanks. Revised patch attached.

It would be good if you could add comments describing the locking scheme
you are changing

Follow-Ups:
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov

References:
- [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Joseph Myers
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Joseph Myers
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Andreas Schwab
- Re: [patch] Fix for bz14333 -- race between atexit() and exit()
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]