This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: libc-2.25.90.pot
- From: Siddhesh Poyarekar <siddhesh at gotplt dot org>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org, Paul Eggert <eggert at cs dot ucla dot edu>, Benno Schulenberg <coordinator at translationproject dot org>
- Date: Wed, 19 Jul 2017 12:45:23 +0530
- Subject: Re: libc-2.25.90.pot
- Authentication-results: sourceware.org; auth=none
- References: <8b9b4e60-f580-e56a-26bc-adb7192ba779@sourceware.org> <6e7f7602-3536-2edb-0cf4-e66a948fdb71@translationproject.org> <f0feca6f-c7f4-6a48-c8dc-cbe6cd4dd7ca@translationproject.org> <c45da7e9-32f9-4b9c-740b-2a3a2d3e3fe0@linaro.org>
On Wednesday 19 July 2017 12:32 AM, Adhemerval Zanella wrote:
> I think these a limitation of xgettext used to generate the pot files.
> Both are similar defined:
>
> timezone/zic.c
>
> # msgid "\"%s\", line %"
> 487 fprintf(stderr, _("\"%s\", line %"PRIdLINENO": "), filename, linenum);
>
> # msgid " (rule from \"%s\", line %"
> 490 fprintf(stderr, _(" (rule from \"%s\", line %"PRIdLINENO")")
>
> And 'PRIdLINENO' is defined as
>
> 50 typedef intmax_t lineno;
> 51 #define PRIdLINENO PRIdMAX
>
> Which means we will get different string encodings depending of how
> __PRI64_PREFIX is defined by the ABI.
>
> Both changes came from '92bd70fb' (Update timezone code from tzcode 2017b.) and
> from original tz project it seems to get from cc8aec6ecb1ecc (zic: some
> integer-width fixups). TZ commit log seems to indicate this is just a integer
> cleanup without original from an actual bug or limitation.
>
> Paul I think we can use default %d for ints for these two specific printf to
> make translation work as intended. What do you think?
There are three of those instances and they refer to line numbers in the
timezone data file. If we can assume that the tzdata files are sane
then I suppose we could assume %d for these.
Siddhesh