This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Added Tongan language locale for Tonga


Akhilesh Kumar <akhilesh.k@samsung.com> wrote:

> [BZ #21728]
>       * localedata/locales/to_TO : new file
>       * localedata/SUPPORTED : modified
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>
> ---

I think it is OK if I apply the attached patch.

    diff --git a/localedata/locales/to_TO b/localedata/locales/to_TO
    index 91485aebc7..8912813085 100644
    --- a/localedata/locales/to_TO
    +++ b/localedata/locales/to_TO
    @@ -79,8 +79,7 @@ day  "Sāpate";/
          "Mōnite";/
          "Tūsite";/
          "Pulelulu";/
    -     "Tuʻapule/
    -      lulu";/
    +     "Tuʻapulelulu";/

Only for better readability of the decoded source file.

          "Falaite";/
          "Tokonaki"
     % Abbreviated weekday names (%a)
    @@ -88,13 +87,12 @@ abday  "Sāp";/
            "Mōn";/
            "Tūs";/
            "Pul";/
    -       "TuʻU0061>";/
    +       "Tuʻa";/

Missing <

            "Fal";/
            "Tok"
     % Equivalent of AM PM
     % hengihengi, efiafi
    -am_pm  "hengiheng/
    -       i";/
    +am_pm  "hengihengi";/
            "efiafi"

Better readability of the source.

     %
    @@ -106,18 +104,15 @@ d_t_fmt     "%A %d %b/
     %
     % Appropriate date representation
     % %A %d %b %Y
    -d_fmt       "%A %d %b/
    -170  %Y"
    +d_fmt       "%A %d %b %Y"

What is the 170 doing there?

     %
     % Appropriate time representation
     % %I:%M:%S  %Z
    -t_fmt       "%I:%M:%S/
    -175   %Z"
    +t_fmt       "%I:%M:%S %Z"

What is the 175 doing there? And why two spaces before %Z?

     %
     % Appropriate 12 h time representation (%r)
     % %I:%M:%S %p %Z
    -t_fmt_ampm "%I:%M:%S/
    -%  %p %Z"
    +t_fmt_ampm "%I:%M:%S %p %Z"


     END LC_TIME
     %
     LC_NUMERIC
    @@ -131,9 +126,9 @@ END LC_NUMERIC
     % https://en.wikipedia.org/wiki/Tonga
     % https://en.wikipedia.org/wiki/Tongan_pa%CA%BBanga
     LC_MONETARY
    -% 
    -currency_symbol    "¢"
    -% TOP 
    +% T$
    +currency_symbol    "T$"
    +% TOP
     int_curr_symbol    "TOP "

¢ was not in UTF-8 encoding in the comment. and the currency symbols
is T$ anyway, not ¢.

     % .
     mon_decimal_point  "."
    @@ -167,7 +162,7 @@ LC_MESSAGES
     yesexpr "^[+1yY]"
     % ^[-0nN]
     noexpr  "^[-0nN]"
    -% Yes -> 'Io 
    +% Yes -> 'Io
     yesstr  "'Io"
     % NO -> 'Ikai
     nostr   "'Ikai"
    @@ -184,7 +179,7 @@ LC_ADDRESS
     postal_fmt   "%a%b%s%c"
     % Tonga
     country_name "Tonga"
    -% No code 
    +% No code
     country_post ""
     % http://laendercode.net/en/2-letter-list.html
     % TO
    @@ -212,4 +207,3 @@ int_select  "00"
     % 676
     int_prefix  "676"
     END LC_TELEPHONE
    -

-- 
Mike FABIAN <mfabian@redhat.com>

diff --git a/localedata/locales/to_TO b/localedata/locales/to_TO
index 91485aebc7..8912813085 100644
--- a/localedata/locales/to_TO
+++ b/localedata/locales/to_TO
@@ -79,8 +79,7 @@ day  "SÄ?pate";/
      "MÅ?nite";/
      "TÅ«site";/
      "Pulelulu";/
-     "Tuʻapule/
-      lulu";/
+     "Tuʻapulelulu";/
      "Falaite";/
      "Tokonaki"
 % Abbreviated weekday names (%a)
@@ -88,13 +87,12 @@ abday  "SÄ?p";/
        "MÅ?n";/
        "TÅ«s";/
        "Pul";/
-       "TuʻU0061>";/
+       "Tuʻa";/
        "Fal";/
        "Tok"
 % Equivalent of AM PM
 % hengihengi, efiafi
-am_pm  "hengiheng/
-       i";/
+am_pm  "hengihengi";/
        "efiafi"
 
 %
@@ -106,18 +104,15 @@ d_t_fmt     "%A %d %b/
 %
 % Appropriate date representation
 % %A %d %b %Y
-d_fmt       "%A %d %b/
-170  %Y"
+d_fmt       "%A %d %b %Y"
 %
 % Appropriate time representation
 % %I:%M:%S  %Z
-t_fmt       "%I:%M:%S/
-175   %Z"
+t_fmt       "%I:%M:%S %Z"
 %
 % Appropriate 12 h time representation (%r)
 % %I:%M:%S %p %Z
-t_fmt_ampm "%I:%M:%S/
-%  %p %Z"
+t_fmt_ampm "%I:%M:%S %p %Z"
 END LC_TIME
 %
 LC_NUMERIC
@@ -131,9 +126,9 @@ END LC_NUMERIC
 % https://en.wikipedia.org/wiki/Tonga
 % https://en.wikipedia.org/wiki/Tongan_pa%CA%BBanga
 LC_MONETARY
-% ¢
-currency_symbol    "¢"
-% TOP 
+% T$
+currency_symbol    "T$"
+% TOP
 int_curr_symbol    "TOP "
 % .
 mon_decimal_point  "."
@@ -167,7 +162,7 @@ LC_MESSAGES
 yesexpr "^[+1yY]"
 % ^[-0nN]
 noexpr  "^[-0nN]"
-% Yes -> 'Io 
+% Yes -> 'Io
 yesstr  "'Io"
 % NO -> 'Ikai
 nostr   "'Ikai"
@@ -184,7 +179,7 @@ LC_ADDRESS
 postal_fmt   "%a%b%s%c"
 % Tonga
 country_name "Tonga"
-% No code 
+% No code
 country_post ""
 % http://laendercode.net/en/2-letter-list.html
 % TO
@@ -212,4 +207,3 @@ int_select  "00"
 % 676
 int_prefix  "676"
 END LC_TELEPHONE
-

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]