Re: [PATCH 1/1] Added Tongan language locale for Tonga.

[Rafal Luzynski <digitalfreak at lingonborough dot com>]

Hi,

This review may be incomplete so please somebody (Mike?)
review it again:

7.07.2017 08:14 Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>
>
> Added Tongan language locale for Tonga

Please leave one empty line after the title line of the commit
comment.

> [BZ #21728]
> * localedata/locales/to_TO : new file
> * localedata/SUPPORTED : modified

No space before the colon, please.

> ---
> localedata/SUPPORTED | 1 +
> localedata/locales/to_TO | 213 +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 214 insertions(+)
> create mode 100644 localedata/locales/to_TO
>
> Signed-off-by: Akhilesh Kumar <akhilesh.k@samsung.com>

IIRC, "Signed-off-by" is not used in glibc.

> [...]
> +% Full month names (%B)
> +% Sanuali, Fepueli, Ma?asi, ?Epeleli, Me, Sune, Siulai, ?Aokosi, Sepitema,
> ?Okatopa, Novema, Tisema

My suggestions:
- use the actual national characters (instead of question marks),
- wrap the line at 72 characters.

So this should be: Sānuali, Fēpueli, Maʻasi, ...

Or don't use the month names in the comment at all, it's not
obligatory.

> +mon "<U0053><U0101><U006E><U0075><U0061><U006C><U0069>";/
> + "<U0046><U0113><U0070><U0075><U0065><U006C><U0069>";/
> + "<U004D><U0061><U02BB><U0061><U0073><U0069>";/

<U02BB> is: Modifier letter turned comma.  Is this what you wanted?
Wouldn't you prefer <U02BC> Modifier letter apostrophe?  Or rather
the correct question shouldn't be what you prefer but rather what
are the proper typographic guidelines for Tongan language.

> + "<U004D><U0061><U02BB><U0061><U0073><U0069>";/

This says "Maʻasi" again, I think you meant "ʻEpeleli".

> + "<U004D><U0113>";/
> + "<U000A><U0053><U0075><U006E><U0065>";/

Please ^^^^ remove <U000A> (newline).

> + "<U0053><U0069><U0075><U006C><U0061><U0069>";/
> + "<U02BB><U0041><U006F><U006B><U006F><U0073><U0069>";/
> + "<U0053><U0065><U0070><U0069><U0074><U0065><U006D><U0061>";/
> + "<U02BB><U004F><U006B><U0061><U0074><U006F><U0070><U0061>";/
> + "<U004E><U014D><U0076><U0065><U006D><U0061>";/
> + "<U0054><U012B><U0073><U0065><U006D><U0061>"
> +% Abbreviated month names (%b)
> +% San, Fep, Ma?a, ?Epe, Me, Sun, Siu, ?Aok, Sep, ?Oka, Nov, Tis

Again I suggest using the actual national characters or removing
this comment.

> +abmon "<U0053><U0101><U006E>";/
> + "<U0046><U0113><U0070>";/
> + "<U004D><U0061><U02BB><U0061>";/
> + "<U004D><U0061><U02BB><U0061>";/

Again "Maʻa" repeated twice, should be "ʻEpe".

> + "<U004D><U0113>";/
> + "<U000A><U0053><U0075>";/

Again ^^^^^ newline and this says "Su", probably you meant "Sun"
which should be "<U0053><U0075><U006E>".

> [...]
> +% Full weekday names (%A)
> +% Sapate , Monite , Tusite , Pulelulu , Tu?apulelulu , Falaite , Tokonaki

Again I suggest the actual national characters and no space before comma:
Sāpate, Mōnite, Tūsite, ...

> +day "<U0053><U0101><U0070><U0061><U0074><U0065>";/
> + "<U004D><U014D><U006E><U0069><U0074><U0065>";/
> + "<U0054><U016B><U0073><U0069><U0074><U0065>";/
> + "<U0050><U0075><U006C><U0065><U006C><U0075><U006C><U0075>";/
> +
> "<U0054><U0075><U003F><U0061><U0070><U0075><U006C><U0065><U006C><U0075><U006C><U0075>";/

Should it really be a question mark <U003F>? I think you meant
"Tuʻapulelulu" which should start: "<U0054><U0075><U02BB>..."
(if Modifier letter turned comma is what you want).

> + "<U0046><U0061><U006C><U0061><U0069><U0074><U0065>";/
> + "<U0054><U006F><U006B><U006F><U006E><U0061><U006B><U0069>"
> +% Abbreviated weekday names (%a)
> +% Sap , Mon , Tus , Pul , Tu?a , Fal , Tok

Again national characters and no space before comma:
Sāp, Mōn, Tūs, ...

> +abday "<U0053><U0101><U0070>";/
> + "<U004D><U014D><U006E>";/
> + "<U0054><U016B><U0073>";/
> + "<U0050><U0075><U006C>";/
> + "<U0054><U0075><U003F>";/

This says ""Tu?", if you meant "Tuʻa" it should be
"<U0054><U0075><U02BB><U0061>".

> [...]
> +% Appropriate date and time representation
> +% %a %d %b %Y %I:%M:%S %p %Z
> +d_t_fmt
> "<U0025><U0061><U0020><U0025><U0064><U0020><U0025><U0042><U0020><U0025><U0059><U0020><U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0025><U0070><U0020><U0054><U004F><U0054>"

This actually says: ""%a %d %B %Y %I:%M:%S %p TOT". I think you
meant "%Z" instead of "TOT".

> [...]
> +% Appropriate time representation
> +% %I:%M:%S  %Z
> +t_fmt
> "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020><U0020><U0025><U005A>"

Two spaces before "%Z" - is this what you meant?

> +% t_fmt "<U0025><U0072>"

Is this comment relevant?

> [...]
> +LC_MONETARY
> +% ¢
> +currency_symbol "<U00A2>"
> +% Pa?anga (TOP)

Did you mean "Paʻanga"?

> [...]
> +LC_MESSAGES
> +%
> https://www.tripadvisor.com/Travel-g294141-s604/Tonga:Important.Phrases.html
> +% ^[+1yY] <FixMe>

<FixMe> means you'd like to fix something.  Please fix.

> +yesexpr
> "<U005E><U005B><U0031><U0079><U0059><U0101><U0100><U00E4><U00C4><U0061><U0041><U005D><U002E><U002A>"

This says: "^[1yYāĀäÄaA].*"  The letters in the bracket should also
contain "+", as the comment suggests.  Why all these variants of "A"?
Are they correct here?  Shouldn't there be also "O" (the letter, not
zero)?

> +% ^[-0nN] <FixMe>

<FixMe> again.

> +noexpr
> "<U005E><U005B><U0030><U006E><U004E><U006B><U004B><U005D><U002E><U002A>"

This says "^[0nNkK].*"  Again, should also be "-".

For the first time I see this kind of a problem: in this language both
"yes" and "no" start with the same letter.  I really don't know how to
fix it.  How do the applications work in the Tongan language?
I mean the message boxes where "Yes" and "No" should have the first
letters underlined and working as shortcuts.

> +% Yes -> 'Io
> +yesstr "<U0027><U0049><U006F>"

For consistency this should be "ʻIo" and "<U02BB><U0049><U006F>".

> +% NO -> 'Ikai
> +nostr "<U0027><U0049><U006B><U0061><U0069>"

Same: "ʻIkai" and "<U02BB><U0049><U006B><U0061><U0069>".

> [...]
> +LC_NAME
> +copy "en_US"
> +END LC_NAME

"en_US" - are you sure?

Again I emphasize that this review is really quick and may be incomplete.

Regards,

Rafal