This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add new Tok-Pisin locales.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Chris Leonard <cjlhomeaddress at gmail dot com>, akhilesh dot k at samsung dot com
- Cc: Mike FABIAN <mfabian at redhat dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, PANKAJ MISHRA <pankaj dot m at samsung dot com>, 이학봉 <hakbong5 dot lee at samsung dot com>, Maninder Singh <maninder1 dot s at samsung dot com>
- Date: Thu, 6 Jul 2017 09:55:43 -0400
- Subject: Re: [PATCH 1/2] Add new Tok-Pisin locales.
- Authentication-results: sourceware.org; auth=none
- References: <1499058991-5516-1-git-send-email-akhilesh.k@samsung.com> <s9dshibp37y.fsf@redhat.com> <CGME20170703051950epcas5p3e27d7b3570a8ced2fd1fc2d8b2a815fa@epcms5p4> <s9dbmozm9td.fsf@redhat.com> <20170705120727epcms5p4965b758a4d5c1a07a65b9f2b368bf2f8@epcms5p4> <CAHdAatbX2qWiCAPAiC9GBWyvk7CVgMiuD94_fUPXJwBNzofgiw@mail.gmail.com>
On 07/06/2017 12:12 AM, Chris Leonard wrote:
> On Wed, Jul 5, 2017 at 8:07 AM, AKHILESH KUMAR <akhilesh.k@samsung.com> wrote:
>>
>>>> Akhilesh Kumar <akhilesh.k@samsung.com> wrote:
>>>>
>>>>> [BZ #21694]
>>>>> Added tok-pisin language locale for Papua New Guinea.
>>>>>
>>>
>>> According to my comments in my previous mail, I suggest to
>>> add the attached patch to your patch.
>>
>> Hi Mike
>>
>> Thanks for review comments
>>
>> all comments are integared and changes resent for review
>>
>> https://sourceware.org/ml/libc-alpha/2017-07/msg00140.html
>>
>>
>> Additional changes to fix compilation issues
>> -% %n%s%z%C
>> +% %a%s%z%C
>>
>> # localedef --no-archive -i tpi_PG --charmap=UTF-8 /usr/lib/locale/tpi_PG.utf8
>> LC_ADDRESS: invalid escape `%n' sequence in field `postal_fmt'
>> no output file produced because warnings were issued
>
> Dear friends of Oceania from Samsung,
>
> I'm a big fan of getting new languages into glibc, but we need to take
> some care to get it right, especially when it is being done by people
> who may not be native speakers (or directly collaborating with native
> speakers).
>
> For instance, this Tok Pisin locale does not properly establish the
> sort order of the 4 digraphs used by Tok Pisin.
>
> https://en.wikipedia.org/wiki/Tok_Pisin#Alphabet
>
> The Māori (Te Reo) locale provides an excellent example to be followed
> for sorting digraphs properly. Note, there are only two in the Māori
> (Te Reo) alpbabet.
>
> https://sourceware.org/git/?p=glibc.git;a=blob;f=localedata/locales/mi_NZ
>
> Looking forward to the improvements to this new locale.
If there are defects in the glibc locale we should file bugs for the defects
such that we can track the required fixes.
--
Cheers,
Carlos.